Hide Info,State,Instance #2856
Merged
Hide Info,State,Instance #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
approved these changes
Dec 20, 2024
bugadani
reviewed
Jan 6, 2025
| @@ -86,11 +86,19 @@ mod placeholder; | |||
| pub use placeholder::NoPin; | |||
|
|
|||
| #[cfg(soc_etm)] | |||
| pub mod etm; | |||
| crate::unstable_module! { | |||
There was a problem hiding this comment.
Did these really need separate macro calls?
There was a problem hiding this comment.
the way the macro currently works - yes
I don't see a way to make the macro work here without turning it into a proc-macro (and I'm not sure it's worth it)
There was a problem hiding this comment.
What do you mean, what's wrong with this?
crate::unstable_module! {
#[cfg(soc_etm)]
pub mod etm;
#[cfg(lp_io)]
pub mod lp_io;
#[cfg(all(rtc_io, not(esp32)))]
pub mod rtc_io;
}There was a problem hiding this comment.
mhhh - I remember it was causing some problem with the lp_gpio macro before but now it's working this way - so we can change to one macro invocation again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Closes #2766 but not fully #2697 (besides hiding
AlternateFunction- posted an open question there)Additionally it marks
gpio/etm,gpio/lp_io,gpio/rtc_io,gpio/etm,RtcPin,RtcFunction,WakeEvent,RtcPinWithResistors,AnalogPin,TouchPinas unstable.TouchPinis feature gated by#[cfg(touch)]No CHANGELOG.md entry (can add it if we want it - seems unnecessary since one of the main things to mention for the next release is the introduction of the unstable feature)
Testing
n.a. / builds passing
inspect the generated docs